Author Topic: Path to docker executable in your build environment  (Read 127 times)

cl-

  • Newbie
  • *
  • Posts: 28
    • View Profile
Path to docker executable in your build environment
« on: October 09, 2019, 12:02:20 »
Hi!

Would it be possible to make the path to the docker executable editable for your docker based build environment?

At the moment, the command in your makefile configuration files (inside the bricklib2/cmake folder) include the static path, that is /usr/bin/docker. On a mac, for instance, docker doesn't install into /usr/bin though.

It would be possible for me to change all these occurrences, that's not the question. However, I don't want to change that many files, given that I don't want conflicts in the cloned git repository.


Cheers,
Claudio

borg

  • Tinkerforge Staff
  • Administrator
  • Hero Member
  • *****
  • Posts: 3.142
    • View Profile
Re: Path to docker executable in your build environment
« Reply #1 on: October 10, 2019, 09:39:23 »
I just replaced "/usr/bin/docker" with "docker" for now (we were using "docker" at other places in the Makefile anyway).

If the docker binary is not somewhere in $PATH you can always call make with PATH=$PATH:/your/path to make it work.
Wir sind die Borg, Widerstand ist Spannung durch Stromstärke!

cl-

  • Newbie
  • *
  • Posts: 28
    • View Profile
Re: Path to docker executable in your build environment
« Reply #2 on: October 10, 2019, 14:42:17 »
Thanks! I've seen the changes in bricklib2.
There are also two files in /bricklib/toolchains with the absolute path to docker.

Cheers!

borg

  • Tinkerforge Staff
  • Administrator
  • Hero Member
  • *****
  • Posts: 3.142
    • View Profile
Re: Path to docker executable in your build environment
« Reply #3 on: October 10, 2019, 16:17:26 »
Indeed, it is fixed now.
Wir sind die Borg, Widerstand ist Spannung durch Stromstärke!